Skip to content

Limit page nexts #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaschultz merged 2 commits into from
May 6, 2020
Merged

Limit page nexts #4

jaschultz merged 2 commits into from
May 6, 2020

Conversation

@jaschultz
Copy link
Contributor

@jaschultz jaschultz commented May 5, 2020

Fixes the following issues.

  • Current implementation gets all pages and then slices list based on limit size.
  • Allows no limit to be set by None instead of just guessing at a large number.

@jaschultz jaschultz requested a review from ivailop May 5, 2020 16:11
@jaschultz jaschultz merged commit e924224 into master May 6, 2020
jaschultz added a commit that referenced this pull request May 6, 2020
@jaschultz
Revert "Limit page nexts (#4)"
0e89ac5 
This reverts commit e924224.
@jaschultz jaschultz mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivailop ivailop ivailop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaschultz @ivailop