Added opentelemetry integration. #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Kirilin <win10@list.ru>
sorasful
reviewed
Jun 23, 2022
| {%- endif %} | ||
|
|
||
| {%- if cookiecutter.otlp_enabled == "True" %} | ||
| opentelemetry_endpoint: Optional[str] = None |
There was a problem hiding this comment.
I wonder, if we set otlp_enabled to True wouldn't we want a default endpoint instead of None ?
There was a problem hiding this comment.
It works like this.
If you don't provide any endpoint through environment variables, it won't enable the integration by default, but if you do it will enable tracing and start sending data to the specified endpoint.
There was a problem hiding this comment.
Also you don't always want to trace requests while running local copy of a project.
Signed-off-by: Pavel Kirilin <win10@list.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add opentelemetry integration.
Currently I added raw opentelemetry trace_provider and instrumentations for all libraries I could instrument.
This is a draft request that closes issue #85. I'll add containers for opentelemetry collectors in docker-compose later.
Signed-off-by: Pavel Kirilin win10@list.ru