More UMI Stuff (hts_ExtractUMI and hts_SuperDeduper)#264
Merged
Conversation
added 3 commits
September 20, 2024 13:06
…. SuperDeduper now supports umis in tag and had a column parameter
joe-angell
approved these changes
Oct 24, 2024
| for (const auto &c : get_comment()) { | ||
| idx = c.find("RX:Z:"); | ||
| if (idx != std::string::npos) { | ||
| std::string umi = c.substr(idx + 5); |
Collaborator
There was a problem hiding this comment.
Will the "RX:Z:" portion always be at the end of the comment string?
Collaborator
Author
There was a problem hiding this comment.
It seems to be the standard for the UMI information.
| if (dragen & (del != ':')) { | ||
| throw HtsIOException("Delimiter (--delimiter) must be ':' to be compatible with --DRAGEN parameter"); | ||
| if (dragen & (del != ':' || sep != '+')) { | ||
| throw HtsIOException("Delimiter (--delimiter) must be ':' and Separator (--separator) was be '+' to be compatible with --DRAGEN parameter"); |
Collaborator
There was a problem hiding this comment.
Separator (--separator) was be '+' -> must be
Collaborator
Author
|
Matt and I were talking about making this a release, any thoughts on that or things to change / bugs to fix before we make that happen? |
Collaborator
|
I pinged david on the bug fix he was working on, that's the only thing i
can think of atm.
…On Thu, Oct 24, 2024 at 11:19 AM Bradley N. Jenner ***@***.***> wrote:
Matt and I were talking about making this a release, any thoughts on that
or things to change / bugs to fix before we make that happen?
—
Reply to this email directly, view it on GitHub
<#264 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB555SMIYMYCWNWCSDKYFNTZ5E22NAVCNFSM6AAAAABPB7YO5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGA2TONZYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
---------------
Joe Angell
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this PR has a number of changes.
This one is definitely gonna need some review so let me know if any of you would like to schedule a zoom chat to discuss the changes.