set xmlns for sitemap-news also with gnews_single mode#91
Merged
yellowled merged 1 commit intos9y:masterfrom Mar 1, 2019
Merged
set xmlns for sitemap-news also with gnews_single mode#91yellowled merged 1 commit intos9y:masterfrom
yellowled merged 1 commit intos9y:masterfrom
Conversation
onli
approved these changes
Mar 1, 2019
Member
|
@hannob Thx! 👍 |
Member
|
In fact I missed something: Changes like this should always also raise the version number. Especially important for spartacus plugins to trigger upgrades. I will do that in a separate commit now. |
Member
Member
|
Do we document plugin changes there? But I added a line to the plugin changelog: ca327e3 |
Member
|
No, I just totally missed that this is in |
Member
|
I did at first as well^^ This plugin might as well be a core plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the errors I reported here:
https://board.s9y.org/viewtopic.php?f=3&t=24196
The problem in the code is this: The sitemap xmlns was included conditionally if $gnewsmode is set. However that is only the case for the separate gnews sitemap.
In the case of gnews_single - where the news items are included in the main sitemap - it's not. But it is still required.
There's a check for that and it sets $this->gnewsmode, but after that block, so I had to switch those code blocks around and change the if($gnewsmode) to if($this->gnewsmode).
Please merge.