Skip to content

Update DCA covariance and magnetic field#1059

Merged
pinkenburg merged 28 commits intosPHENIX-Collaboration:masterfrom
osbornjd:collabMeeting
Jan 25, 2021
Merged

Update DCA covariance and magnetic field#1059
pinkenburg merged 28 commits intosPHENIX-Collaboration:masterfrom
osbornjd:collabMeeting

Conversation

@osbornjd
Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR adds the feature to run the tracking with a constant magnetic field. This produces the best performance plots right now, as Acts assumes a constant field and may have a bug when it is interpreting the field map.

This PR also fixes a bug in the DCA uncertainty calculation. It now uses the rotated covariance matrix back from the Acts basis to the sPHENIX basis.

TODOs (if applicable)

Figure out why Acts has a difficult time interpreting our field map. That is for another PR.

Links to other PRs in macros and calibration repositories (if applicable)

Here is the macros PR which allows running the default Acts chain with either the PHTpcTracker or CASeeder, with either the constant or field map magnetic field.

@sphenix-jenkins-ci sphenix-jenkins-ci bot added CI-cpp-check-PENDING cpp-check is still running. CI-build-gcc-8.3-new-PENDING build-gcc-8.3-new is still running. CI-build-x8664_sl7-scan-PENDING build-x8664_sl7-scan is still running. CI-build-x8664_sl7-clang-PENDING build-x8664_sl7-clang is still running. CI-build-x8664_sl7-new-PENDING build-x8664_sl7-new is still running. labels Jan 20, 2021
@osbornjd
Copy link
Copy Markdown
Contributor Author

BTW the performance plots that will be shown at the 10th sPHENIX collaboration meeting will correspond to the repository in the state given by this PR

@sphenix-jenkins-ci sphenix-jenkins-ci bot added CI-build-x8664_sl7-new-PASS build-x8664_sl7-new passed. CI-DST-readback-PENDING DST-readback is still running. CI-valgrind-PENDING valgrind is still running. CI-track-high-occ-QA-PENDING track-high-occ-QA is still running. CI-build-x8664_sl7-clang-PASS build-x8664_sl7-clang passed. CI-calo-QA-PENDING calo-QA is still running. CI-DST-readback-PASS DST-readback passed. CI-track-low-occ-QA-PENDING track-low-occ-QA is still running. CI-cpp-check-AVAILABLE cpp-check result is available. CI-build-x8664_sl7-scan-PASS build-x8664_sl7-scan passed. CI-calo-QA-AVAILABLE calo-QA result is available. CI-track-high-occ-QA-AVAILABLE track-high-occ-QA result is available. and removed CI-build-x8664_sl7-new-PENDING build-x8664_sl7-new is still running. CI-build-x8664_sl7-clang-PENDING build-x8664_sl7-clang is still running. CI-DST-readback-PENDING DST-readback is still running. CI-cpp-check-PENDING cpp-check is still running. CI-build-x8664_sl7-scan-PENDING build-x8664_sl7-scan is still running. CI-calo-QA-PENDING calo-QA is still running. CI-track-high-occ-QA-PENDING track-high-occ-QA is still running. labels Jan 20, 2021
@sphenix-jenkins-ci sphenix-jenkins-ci bot added CI-DST-readback-PASS DST-readback passed. CI-build-x8664_sl7-clang-PASS build-x8664_sl7-clang passed. CI-cpp-check-AVAILABLE cpp-check result is available. and removed CI-calo-QA-AVAILABLE calo-QA result is available. CI-DST-readback-PENDING DST-readback is still running. CI-build-x8664_sl7-clang-PENDING build-x8664_sl7-clang is still running. CI-cpp-check-PENDING cpp-check is still running. labels Jan 22, 2021
@blackcathj
Copy link
Copy Markdown
Member

There is a temp. problem on the main Jenkins server. The last check failed and let me check into it.

@blackcathj
Copy link
Copy Markdown
Member

OK. Some change in the code introduced a stdout print as following that filled up the disks when QA simulation was launched ....



Global sPHENIX cov : 

0.408596, 0.0346545, -0.403718, 2.56428, 1.52273, 2.78078, 
0.0346545, 0.365808, -0.233651, -4.47635, -2.65696, -4.74909, 
-0.403718, -0.233651, 0.508482, 0.0457749, 0.026519, -0.00816996, 
2.56428, -4.47635, 0.0457749, 196.412, 115.842, 209.174, 
1.52273, -2.65696, 0.026519, 115.842, 68.324, 123.369, 
2.78078, -4.74909, -0.00816996, 209.174, 123.369, 222.771, 

Global sphenix cov after unit conv: 

0.00408596, 0.000346545, -0.00403718, 0.256428, 0.152273, 0.278078, 
0.000346545, 0.00365808, -0.00233651, -0.447635, -0.265696, -0.474909, 
-0.00403718, -0.00233651, 0.00508482, 0.00457749, 0.0026519, -0.000816996, 
0.256428, -0.447635, 0.00457749, 196.412, 115.842, 209.174, 
0.152273, -0.265696, 0.0026519, 115.842, 68.324, 123.369, 
0.278078, -0.474909, -0.000816996, 209.174, 123.369, 222.771, 

Initial Acts covariance: 

0.0346517, 0.000245753, 0.000169061, 8.02193e-07, -0.000337818, -0.000919993, 
0.000245753, 0.210222, 2.33445e-06, -0.000380771, -5.30305e-06, -0.141888, 
0.000169061, 2.33445e-06, 1.35012e-06, 3.73646e-09, -4.85983e-06, -6.40508e-06, 
8.02193e-07, -0.000380771, 3.73646e-09, 1.07328e-06, -6.71238e-09, 0.0002565, 
-0.000337818, -5.30305e-06, -4.85983e-06, -6.71238e-09, 4.03058e-05, 1.98045e-05, 
-0.000919993, -0.141888, -6.40508e-06, 0.0002565, 1.98045e-05, 1.09579, 

....

@osbornjd
Copy link
Copy Markdown
Contributor Author

osbornjd commented Jan 22, 2021

I made a mistake and forgot to turn the verbosity of the covariance matrix calculator to off (Tony notified me of this also). I pushed the change in this commit. Sorry for overwhelming Jenkins... but it should be fixed now and would just require restarting the build, I think.

Actually, it looks like Jenkins never restarted after I pushed the remove verbosity commit.

@sphenix-jenkins-ci sphenix-jenkins-ci bot added CI-cpp-check-PENDING cpp-check is still running. CI-build-x8664_sl7-clang-PENDING build-x8664_sl7-clang is still running. CI-build-x8664_sl7-new-PENDING build-x8664_sl7-new is still running. CI-build-x8664_sl7-new-PASS build-x8664_sl7-new passed. CI-DST-readback-PENDING DST-readback is still running. CI-DST-readback-PASS DST-readback passed. and removed CI-cpp-check-AVAILABLE cpp-check result is available. CI-build-x8664_sl7-clang-PASS build-x8664_sl7-clang passed. CI-build-x8664_sl7-new-PASS build-x8664_sl7-new passed. CI-build-x8664_sl7-new-PENDING build-x8664_sl7-new is still running. CI-DST-readback-PASS DST-readback passed. CI-DST-readback-PENDING DST-readback is still running. labels Jan 22, 2021
@sphenix-jenkins-ci
Copy link
Copy Markdown

Build & test report

Report for commit 8755fd489015c763ba1c31653af35abe2baf80c9:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci

This comment has been minimized.

@osbornjd
Copy link
Copy Markdown
Contributor Author

osbornjd commented Jan 25, 2021

@blackcathj I see a valgrind error but the page comes up blank with a java stack trace - was there an issue with Jenkins?

@blackcathj
Copy link
Copy Markdown
Member

@blackcathj I see a valgrind error but the page comes up blank with a java stack trace - was there an issue with Jenkins?

Jenkins server was rebooted during the weekend which unfortunately wipe out the webpage format of previous reports. Nonetheless, we can always access the archived XML valgrind report as on the job summary page. As we have a large number of valgrind error at the moment, the XML report would be easier to search through

@sphenix-jenkins-ci
Copy link
Copy Markdown

Build & test report

Report for commit d5eb2af8e9f96a67efd8a310adf26b3ca92ce592:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-build-gcc-8.3-new-PASS build-gcc-8.3-new passed. CI-build-x8664_sl7-clang-PASS build-x8664_sl7-clang passed. CI-build-x8664_sl7-new-PASS build-x8664_sl7-new passed. CI-build-x8664_sl7-scan-PASS build-x8664_sl7-scan passed. CI-calo-QA-AVAILABLE calo-QA result is available. CI-cpp-check-AVAILABLE cpp-check result is available. CI-DST-readback-PASS DST-readback passed. CI-track-high-occ-QA-AVAILABLE track-high-occ-QA result is available. CI-track-low-occ-QA-AVAILABLE track-low-occ-QA result is available. CI-valgrind-AVAILABLE valgrind result is available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants