PennyLane integration into squlearn#241
Merged
David-Kreplin merged 117 commits intosQUlearn:developfrom Apr 15, 2024
Merged
Conversation
David-Kreplin
changed the title
MoritzWillmann
requested changes
Apr 12, 2024
Collaborator
MoritzWillmann
left a comment
MoritzWillmann
left a comment
There was a problem hiding this comment.
Great Contribution. Just some comments to try to clean this code a bit. Also recheck consistency naming wise. e.g. I had the feeling that there were inconsistencies in the use of observable and operator.
MoritzWillmann
approved these changes
Apr 15, 2024
Collaborator
MoritzWillmann
left a comment
MoritzWillmann
left a comment
There was a problem hiding this comment.
I think it looks good 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PennyLane support in squlearn. Currently at beta status