Skip to content

Comments section#51

Merged
saadpasta merged 6 commits intosaadpasta:masterfrom
xzebra:comments-section
Jul 22, 2020
Merged

Comments section#51
saadpasta merged 6 commits intosaadpasta:masterfrom
xzebra:comments-section

Conversation

@xzebra
Copy link
Copy Markdown
Contributor

@xzebra xzebra commented Jul 21, 2020

As a temporary addition, I implemented the comments section. I haven't come up with a great solution to posting comments in an elegant way, as a Markdown editor would be required.

I included another Markdown element to display the comments. This made me reuse the HyperLink and CodeBlock overrides for the Markdown component so I made an include for those. In addition, the Comment component reuses the AuthorDetails, AuthorAvatar... components, you could create new ones if desired.

To end, I changed a few styles to make the comments look OK and set position: static in PostReaction as now you can't use bottom as reference (I'm sure this could've been done better).

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/react-blog-github/g2ehcma6m
✅ Preview: https://react-blog-github-git-fork-xzebra-comments-section.saadpasta.vercel.app

@saadpasta
Copy link
Copy Markdown
Owner

@xzebra Look's awesome. I'll have a look

Copy link
Copy Markdown
Owner

@saadpasta saadpasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's great for now. Can you add a button for add a comment that redirect to that issue comment input that would be great

@xzebra
Copy link
Copy Markdown
Contributor Author

xzebra commented Jul 22, 2020

Sure! I will work on it

@saadpasta saadpasta merged commit 41bcd2a into saadpasta:master Jul 22, 2020
@saadpasta
Copy link
Copy Markdown
Owner

@allcontributors please add @xzebra for code and idea

@allcontributors
Copy link
Copy Markdown
Contributor

@saadpasta

We had trouble processing your request. Please try again later.

@saadpasta
Copy link
Copy Markdown
Owner

@allcontributors please add @xzebra for code

@allcontributors
Copy link
Copy Markdown
Contributor

@saadpasta

I've put up a pull request to add @xzebra! 🎉

@allcontributors
Copy link
Copy Markdown
Contributor

@saadpasta

I've updated the pull request to add @xzebra! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants