Skip to content

fix: contain settings shell scroll and stabilize validation suites#10

Merged
saagpatel merged 1 commit into
masterfrom
codex/fix/fix-settings-scroll-white-background
Mar 25, 2026
Merged

fix: contain settings shell scroll and stabilize validation suites#10
saagpatel merged 1 commit into
masterfrom
codex/fix/fix-settings-scroll-white-background

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

What

  • Fix the Settings shell scroll and white-background leak in the desktop app
  • Stabilize the validation suites that were failing for unrelated local-storage and test-setup reasons
  • Clean up the local search API setup so its test lane runs reliably

Why

  • Scrolling down on Settings could reveal a white surface in the installed app
  • Several failing validation lanes were masking real regressions and slowing down release confidence
  • The search API test setup had a dependency and Python-version mismatch that blocked local verification

How

  • Contain scrolling inside the revamp shell and paint the shell and Settings surfaces directly
  • Add a shared in-memory storage setup for Vitest and enable the admin flag explicitly in the admin UI test
  • Refresh the updated visual baseline after the intended shell change
  • Pin an installable flask-limiter version and document Python 3.11 for local search-api setup
  • Remove broken pre-commit ESLint lint-staged entries because the repo does not currently ship an ESLint config for that hook path

Testing

  • pnpm run check:monorepo-readiness
  • pnpm exec playwright test
  • pnpm test:ci
  • pnpm search-api:test

Risks

  • The shell visual snapshot changed intentionally because the surface/background treatment changed
  • Local search-api setup now assumes Python 3.11 for the pinned scientific stack
  • The lint-staged change keeps formatting on commit but no longer runs ESLint from the hook until a repo ESLint config is added

Performance impact

  • No expected runtime performance regression
  • The user-facing fix is CSS/layout only, and the remaining changes are test and tooling stabilization

Lockfile rationale

  • No lockfile changes were needed

Screenshots

  • UI verification was covered by the refreshed Playwright visual snapshot for the updated shell appearance

@saagpatel saagpatel merged commit 3031d21 into master Mar 25, 2026
24 of 27 checks passed
@saagpatel saagpatel deleted the codex/fix/fix-settings-scroll-white-background branch March 25, 2026 18:22
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29d584e10e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

padding: var(--as-space-6);
min-height: 0;
flex: 1;
overflow: hidden;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore vertical scroll for oversized right rail

Setting .as-shell__content to overflow: hidden traps the diagnostics rail when its content exceeds the viewport height (common on shorter desktop windows, since the rail renders multiple stacked panels). Because .as-shell__rail itself still has no scrolling behavior, users can no longer reach the lower actions/guidance items that were previously reachable via page scroll. Add a scroll container on the rail or avoid hiding overflow at this level.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants