docs: portfolio disposition and pnpm workspace fix#23
Merged
Conversation
Adds docs/PORTFOLIO-DISPOSITION.md. Completes the pnpm-workspace.yaml allowBuilds template (esbuild=true) to unblock the husky pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes bundled because they cross-validate each other:
docs/PORTFOLIO-DISPOSITION.md— documents that the closeout packet (PR feat(app): harden export flow and release gates #4) merged 2026-03-24 and the row is now Release Frozen waiting on Apple + Windows signing credentials.pnpm-workspace.yaml— completes theallowBuildstemplate (esbuild: true) that was left as a literal "set this to true or false" stub. The stub broke the husky pre-commit pipeline.Why
Portfolio operating system tracked a "closeout completion" packet on ContentEngine. The closeout itself merged in March, but the row kept cycling because the disposition wasn't documented. This doc closes the loop and tells portfolio OS to suspend overdue counting until signing is wired.
The workspace fix is discovered-and-fixed in the same change because every commit on this repo was hitting the same
ERR_PNPM_IGNORED_BUILDSfailure. Surfacing it separately would be busywork; bundling it makes the disposition doc actually mergeable.How
PORTFOLIO-DISPOSITION.md— same shape as DesktopPEt's just-merged version.true.Testing
pnpm installnow completes cleanly with the esbuild postinstall running.Risk / Notes
The workspace fix opts in to running
esbuild's postinstall script. esbuild's postinstall is standard build-script behavior; this is the expected configuration for this pnpm version. If the operator preferredfalsefor security review reasons, the original stub gave no path forward — every commit was already blocked.🤖 Generated with Claude Code