Recognize catalog-backed infra context#144
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6db57f21b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def has_substantive_readme_support( | ||
| primary_context_file: str, context_files: list[str], readme_char_count: int | ||
| ) -> bool: | ||
| context_file_names = {Path(item).name for item in context_files} |
There was a problem hiding this comment.
Require top-level primary context support
When discovery returns nested context files, such as docs/AGENTS.md, this basename-only set treats it the same as a top-level AGENTS.md. A repo with that nested file plus a substantive top-level README but no top-level AGENTS.md/CLAUDE.md will satisfy this helper, so reconciliation can promote an otherwise README-only minimum-viable active infra repo to standard, overstating the primary context contract; compare the relative paths directly before enabling the promotion.
Useful? React with 👍 / 👎.
| if declared_values.get("category") != "infrastructure": | ||
| return raw_context_quality |
There was a problem hiding this comment.
Require catalog-backed infrastructure category
For repos whose catalog sets active/high/maintain but omits category, declared_values["category"] can still be infrastructure via the legacy registry fallback. In that scenario this new predicate promotes minimum-viable to standard and records workspace+catalog, even though the infrastructure evidence came from an old derived surface rather than the catalog-backed contract this rule is meant to require; check the category provenance or the repo/group catalog entries instead.
Useful? React with 👍 / 👎.
|
Post-merge Codex finding disposition: both portfolio context promotion findings were verified against current origin/main and are now tracked in #145. |
Summary
Verification
Notes