Skip to content

chore(codeql): document empty fallback catches#17

Merged
saagpatel merged 1 commit into
mainfrom
codex/document-empty-except-fallbacks
May 18, 2026
Merged

chore(codeql): document empty fallback catches#17
saagpatel merged 1 commit into
mainfrom
codex/document-empty-except-fallbacks

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

What

  • Adds explanatory comments to intentional empty fallback catches across analyzers, web routes, CLI fallbacks, exports, and targeted tests.
  • Documents one additional non-alert source fallback to avoid leaving the same pattern behind.

Why

  • Clears the largest remaining CodeQL note-level cluster: py/empty-except.
  • Makes best-effort fallback behavior easier to audit without changing runtime behavior.

How

  • Keeps existing behavior intact and explains each intentional swallow point in place.

Testing

  • python3 -m pytest tests/test_serve.py tests/test_plan_campaign.py tests/test_draft_readmes.py tests/test_analyzers.py tests/test_readme_suggestions.py tests/test_issue_creator.py tests/test_excel_export_registry_helpers.py tests/test_cloner.py tests/test_briefing.py tests/test_web_export.py -q -p no:cacheprovider — 276 passed, 1 warning
  • ruff check src/ tests/test_plan_campaign.py tests/test_draft_readmes.py — passed
  • source scan for uncommented except: pass patterns — no matches in src/
  • python3 -m pytest -q -p no:cacheprovider — 2085 passed, 2 skipped, 1 warning
  • ruff check src/ tests/ — passed

Performance Impact

  • None expected; comments only.

Risk / Notes

  • This is intentionally documentation-only for existing fallback behavior.

@saagpatel saagpatel merged commit f443331 into main May 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant