Skip to content

chore(deps): refresh pnpm lockfile, drop legacy sidecar binary, link portable skills#13

Merged
saagpatel merged 3 commits into
mainfrom
feat/deps-refresh-2026-05-rebased
May 17, 2026
Merged

chore(deps): refresh pnpm lockfile, drop legacy sidecar binary, link portable skills#13
saagpatel merged 3 commits into
mainfrom
feat/deps-refresh-2026-05-rebased

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

Summary

  • Regenerated pnpm-lock.yaml (compatibility refresh)
  • Removed vendored 80MB sidecar src-tauri/binaries/jcc-sidecar-aarch64-apple-darwin (build artifact, not source)
  • Linked 4 portable skills (api-design, migration, notarize, tauri-release) as symlinks under .claude/skills/
  • Added portfolio-context block to CLAUDE.md (post-rebase merge with main's same-section addition)

Why

Captures mid-flight WIP. Sidecar binary is a build artifact, restorable via Tauri build pipeline.

Replaces #12 (which had stale base; rebased onto current main).

Test plan

  • CI passes
  • Tauri build regenerates sidecar from pipeline
  • No production code references the removed binary

🤖 Generated with Claude Code

…portable skills

- pnpm-lock.yaml regenerated
- Deleted vendored 80MB jcc-sidecar binary (build artifact, not source)
- Linked 4 portable skills (api-design, migration, notarize, tauri-release)
- CLAUDE.md additions

Mid-flight WIP captured for review; not pushed.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6146d7bd0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/skills/api-design
@@ -0,0 +1 @@
/Users/d/.claude/portable-skills/api-design No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use repo-relative skill links

These new skill entries are absolute symlinks into /Users/d, so every checkout that is not on that exact machine/account gets a dangling .claude/skills/* entry and Claude cannot load the project skills the commit is trying to provide. Commit the skill directories or make the links relative to files inside the repo so the setup works for other developers and CI checkouts.

Useful? React with 👍 / 👎.

saagpatel added 2 commits May 17, 2026 03:15
pyo3 0.24.0 (transitively required by pydantic-core) supports up to
Python 3.13. Workflow was pinning '3.14' which fails the wheel build.
Project spec is 3.12+, so pinning to 3.12 matches the documented stack
and unblocks the sidecar CI lane.

Note: Tauri test-backend job is failing separately on missing glib-2.0
system libs (pre-existing — main has been CI-red since 2026-04-13).
Out of scope for this PR.
@saagpatel saagpatel merged commit 262ada3 into main May 17, 2026
2 of 6 checks passed
@saagpatel saagpatel deleted the feat/deps-refresh-2026-05-rebased branch May 17, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant