Skip to content

chore: add fly.toml for deployment configuration#3

Merged
saagpatel merged 1 commit into
mainfrom
feat/SlackIncidentBot-build-readiness
Mar 29, 2026
Merged

chore: add fly.toml for deployment configuration#3
saagpatel merged 1 commit into
mainfrom
feat/SlackIncidentBot-build-readiness

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

Adds fly.toml to complete build_readiness score from 0.8 to 1.0.

Repo already has Dockerfile, Makefile, and .env.example. This adds the missing deploy configuration for Fly.io.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a83f33c4e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread fly.toml
[build]

[http_service]
internal_port = 8080
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align Fly internal port with app listen port

internal_port is set to 8080, but this service listens on config.port whose default is 3000 (src/config.rs), and the container is also configured around port 3000 (Dockerfile EXPOSE 3000 and healthcheck on localhost:3000). Because this fly.toml does not set PORT=8080, Fly will proxy to a port the app is not listening on, causing failed health checks and unreachable HTTP endpoints after deployment.

Useful? React with 👍 / 👎.

@saagpatel saagpatel merged commit d80105e into main Mar 29, 2026
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant