Skip to content

Logger package maintenance#506

Merged
Jayden Chan (jayden-chan) merged 9 commits into
masterfrom
jayden/logger-maintenance
May 27, 2026
Merged

Logger package maintenance#506
Jayden Chan (jayden-chan) merged 9 commits into
masterfrom
jayden/logger-maintenance

Conversation

@jayden-chan

Copy link
Copy Markdown
Member

Description of the change

Updated logger package to modern versions of TypeScript and Node.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer

Code review

  • Security impacts of this change have been considered

Jayden Chan (jayden-chan) and others added 4 commits May 27, 2026 09:59
This bumps the minimum supported NodeJS version to 24 so it will be a
breaking change.
This commit was generated by GitHub Actions CI
Copilot AI review requested due to automatic review settings May 27, 2026 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernizes the @saasquatch/logger package by updating its TypeScript/Node toolchain: converts to ESM, targets Node 24/26 with nodenext module resolution, tightens compiler options, adds explicit type import qualifiers, and refreshes dev dependencies/lockfile.

Changes:

  • Switches the package to "type": "module", rewrites tsconfig.json for Node 24 with stricter options, and updates engines to ^24 || ^26.
  • Updates source imports to use .ts extensions and type modifiers (required by verbatimModuleSyntax and rewriteRelativeImportExtensions), and switches index re-exports to export { type X } form.
  • Bumps @types/express, @types/node, adds typescript ^6.0.3 as a dev dependency, and regenerates the lockfile to v3.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/logger/tsconfig.json Adopts Node 24 preset, stricter compiler options, ESNext libs, and rewriteRelativeImportExtensions.
packages/logger/package.json Sets type: module, bumps engines to `^24
packages/logger/package-lock.json Regenerated to lockfile v3 reflecting new dep versions; engines.node value diverges from package.json.
packages/logger/src/index.ts Re-orders/re-exports types using type modifier and adds .ts import extensions.
packages/logger/src/logger.ts Adds type modifiers and .ts extension on local imports.
packages/logger/src/format.ts Adds .ts import extension and trailing commas.
packages/logger/src/config.ts Makes Writable a type-only import; switches process.env.NODE_ENV to index access for noPropertyAccessFromIndexSignature.
packages/logger/src/plugins.ts Reorders imports, uses .ts extensions, and bracket access on res.locals keys.
packages/logger/.gitignore Ignores TypeScript incremental build info files.
Files not reviewed (1)
  • packages/logger/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/logger/package-lock.json Outdated
Comment thread packages/logger/src/config.ts Outdated
Comment thread packages/logger/package.json Outdated
This commit was generated by GitHub Actions CI

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • packages/logger/package-lock.json: Language not supported

Copilot AI review requested due to automatic review settings May 27, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/logger/package-lock.json: Language not supported

Comment thread packages/logger/CHANGELOG.md
@jayden-chan Jayden Chan (jayden-chan) merged commit a23e95f into master May 27, 2026
10 of 11 checks passed
@jayden-chan Jayden Chan (jayden-chan) deleted the jayden/logger-maintenance branch May 27, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants