Logger package maintenance#506
Merged
Merged
Conversation
This bumps the minimum supported NodeJS version to 24 so it will be a breaking change.
This commit was generated by GitHub Actions CI
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes the @saasquatch/logger package by updating its TypeScript/Node toolchain: converts to ESM, targets Node 24/26 with nodenext module resolution, tightens compiler options, adds explicit type import qualifiers, and refreshes dev dependencies/lockfile.
Changes:
- Switches the package to
"type": "module", rewritestsconfig.jsonfor Node 24 with stricter options, and updatesenginesto^24 || ^26. - Updates source imports to use
.tsextensions andtypemodifiers (required byverbatimModuleSyntaxandrewriteRelativeImportExtensions), and switches index re-exports toexport { type X }form. - Bumps
@types/express,@types/node, addstypescript^6.0.3 as a dev dependency, and regenerates the lockfile to v3.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/logger/tsconfig.json | Adopts Node 24 preset, stricter compiler options, ESNext libs, and rewriteRelativeImportExtensions. |
| packages/logger/package.json | Sets type: module, bumps engines to `^24 |
| packages/logger/package-lock.json | Regenerated to lockfile v3 reflecting new dep versions; engines.node value diverges from package.json. |
| packages/logger/src/index.ts | Re-orders/re-exports types using type modifier and adds .ts import extensions. |
| packages/logger/src/logger.ts | Adds type modifiers and .ts extension on local imports. |
| packages/logger/src/format.ts | Adds .ts import extension and trailing commas. |
| packages/logger/src/config.ts | Makes Writable a type-only import; switches process.env.NODE_ENV to index access for noPropertyAccessFromIndexSignature. |
| packages/logger/src/plugins.ts | Reorders imports, uses .ts extensions, and bracket access on res.locals keys. |
| packages/logger/.gitignore | Ignores TypeScript incremental build info files. |
Files not reviewed (1)
- packages/logger/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ian hitchcock (ianhitchcock)
previously approved these changes
May 27, 2026
This commit was generated by GitHub Actions CI
38dda85
ian hitchcock (ianhitchcock)
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Updated logger package to modern versions of TypeScript and Node.
Type of change
Checklists
Development
Paperwork
Code review