Avb/audit fixes #48
Merged
Avb/audit fixes #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
avb/audit-fixes
branch
2 times, most recently
from
a7fffcf to
508f3c2
Compare
test: fix bulloak warning in on cancel hook
andreivladbrg
force-pushed
the
avb/audit-fixes
branch
from
2a24055 to
694feba
Compare
docs: polish comments
smol-ninja
force-pushed
the
avb/audit-fixes
branch
from
140ed00 to
d655424
Compare
smol-ninja
requested changes
Oct 9, 2025
smol-ninja
requested changes
Oct 9, 2025
tests/integration/concrete/configure-next-round/configureNextRound.tree
Outdated
Show resolved
Hide resolved
tests/integration/concrete/configure-next-round/configureNextRound.t.sol
Show resolved
Hide resolved
tests/integration/concrete/on-sablier-lockup-cancel/onSablierLockupCancel.t.sol
Outdated
Show resolved
Hide resolved
tests/integration/concrete/on-sablier-lockup-cancel/onSablierLockupCancel.t.sol
Show resolved
Hide resolved
tests/integration/concrete/on-sablier-lockup-cancel/onSablierLockupCancel.t.sol
Outdated
Show resolved
Hide resolved
tests/integration/concrete/on-sablier-lockup-cancel/onSablierLockupCancel.t.sol
Outdated
Show resolved
Hide resolved
tests/integration/concrete/on-sablier-lockup-cancel/onSablierLockupCancel.tree
Show resolved
Hide resolved
CergyK
reviewed
Oct 13, 2025
CergyK
reviewed
Oct 13, 2025
smol-ninja
approved these changes
Oct 13, 2025
Member
|
Good work Andrei, I am going to merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these audit findings:
Note: used low-level calls for the token getters in
_hasRequiredInterface, i like this approach more