[6.0] fix(http/client): prefer CURLOPT_PROTOCOLS_STR over deprecated bitmask constants#275
Merged
phil-davis merged 4 commits intosabre-io:6.0from Apr 27, 2026
Merged
Conversation
…k constants CURLOPT_PROTOCOLS and CURLOPT_REDIR_PROTOCOLS are deprecated at the libcurl level. When PHP eventually removes the bitmask constants the defined() guards will silently skip protocol restrictions. This could once become a security issue. It's not an issue right now. Prefer the string-based constants introduced in PHP 8.3 with fallback to bitmask for older versions. This is not an urgent fix and I think it's BC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 6.0 #275 +/- ##
============================================
+ Coverage 94.27% 94.28% +0.01%
- Complexity 260 262 +2
============================================
Files 15 15
Lines 873 875 +2
============================================
+ Hits 823 825 +2
Misses 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #272 to 6.0