Skip to content

Conversation

@staabm
Copy link
Member

@staabm staabm commented Dec 7, 2015

didnt found the comments in which we discussed this topic therefore starting from scratch.
hopefully all points are adressed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to propose a better name.. couldnt get better then this right now

@evert evert added this to the 1.3 milestone Dec 8, 2015
@evert evert self-assigned this Dec 8, 2015
@evert
Copy link
Member

evert commented Dec 8, 2015

I think I want to change the behavior of the function a little bit. Instead of :

Sabre\Xml\Deserialize\namespaceAware, I think I just want to call it Sabre\Xml\Deserializer\keyValue.

By default I want to give it the same behavior as Sabre\Xml\Element\KeyValue, but if you specify the $namespace argument (which will be optional) it will strip the namespace, but only from the elements within that namespace, and leave the others intact.

So basically, hold on a second. I will take your PR and use it as a basis for this =)

@staabm
Copy link
Member Author

staabm commented Dec 8, 2015

Sounds great!

@evert
Copy link
Member

evert commented Dec 8, 2015

Oh I didn't realize that in your PR you're already retaining other elements outside of the specified namespace. Really awesome. In that case I'm only changing the function name and docblocks ;)

@evert evert merged commit b774ecd into sabre-io:master Dec 8, 2015
evert added a commit that referenced this pull request Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants