Exercise 1 python. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinacamp2
requested changes
Jul 17, 2024
Owner
sabrinacamp2
left a comment
sabrinacamp2
left a comment
There was a problem hiding this comment.
Nice work.
I didn't see the comments you mentioned or the print statement that you mentioned in the summary, is this all the commits you wanted to add?
| def num_vowels(text): | ||
| """Return the number of vowels in string.""" | ||
| vowels = "aeiou" | ||
| vowels = "aeiouy" |
Owner
There was a problem hiding this comment.
I would recommend defining the vowels outside of the num_vowels() and num_consonants() functions since you are defining this twice (DRY principle). Also, I'm curious, is "y" considered a vowel?
| num = 0 | ||
| for letter in text: | ||
| if letter not in vowels: | ||
| print("consonant", letter) |
Owner
There was a problem hiding this comment.
I might be mistaken, but do you still want something printed out when the function is called?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some comments explaining the code.
Fixed the consonant printing.
Improved the message that is printed out.
Tested with the following strings:
Fixes issue
Fixes #9 python