-
Notifications
You must be signed in to change notification settings - Fork 0
Exercise 1 text. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fix measurements for salt - should be teaspoon convert 240g of flour to cups to use the same units as the other solid ingredients
sabrinacamp2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think the suggested changes greatly improve the clarity of the yellow cake recipe. I would recommend adding the numbered steps to the directions. Otherwise, everything looks great! Nice work.
| ## Recipe for Yellow Cake | ||
|
|
||
| Yellow cake is delicious! This recipie is passed down from my great-great-grandparents. | ||
| Yellow cake is delicious! This recipe is passed down from my great-great-grandparents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on this spelling mistake and others.
| ### Directions | ||
|
|
||
| Preheat the oven to 350 degrees F (175 degrees C). | ||
|
|
||
| Grease a 9x13-inch baking pan. | ||
|
|
||
| Mix the flour, baking powder, and salt together in a medium bowl. | ||
|
|
||
| Beat sugar and shortening together in a large bowl with an electric mixer until light and fluffy. | ||
|
|
||
| Add eggs, one at a time, beating thoroughly after each adding each egg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned in the PR summary that you added numbered steps to the recipe, but I don't see that reflected here. Maybe consider adding numbered steps to your already well outlined and spaced directions.
| @@ -1,25 +1,30 @@ | |||
| ## Recipice for Chocolate Cake | |||
| ## Recipe for Yellow Cake | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of markdown headers.
Description
This pull request fixes the cake recipe to
reduce the amount of salt, and describe the
cake correctly as yellow cake rather than
chocolate cake.
I've added numbered steps to the recipe.
Also there are several spelling errors that I
have corrected.
Fixes issue
Fixes #2 text