perf: cache lazy imports in module globals after first resolution#34
Merged
sacredvoid merged 1 commit intomainfrom Mar 26, 2026
Merged
perf: cache lazy imports in module globals after first resolution#34sacredvoid merged 1 commit intomainfrom
sacredvoid merged 1 commit intomainfrom
Conversation
__getattr__ was calling importlib.import_module() + getattr() on every access. Now sets globals()[name] after first resolution so Python finds the attribute in __dict__ directly on subsequent accesses. ~3x faster for repeated module-level attribute access. Fixes #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__getattr__resolution, caches the result inglobals()viaglobals()[name] = attr__dict__directly, bypassing__getattr__Fixes #33
Test plan