[dev] Avatar (User Icon) Image Fixes/Enhancements for PBI AB#16313#45
Merged
oilywithraybans merged 3 commits intodevfrom May 20, 2019
Merged
[dev] Avatar (User Icon) Image Fixes/Enhancements for PBI AB#16313#45oilywithraybans merged 3 commits intodevfrom
oilywithraybans merged 3 commits intodevfrom
Conversation
* Add an `xxlarge` size option for `<Icon>` component * Add logic to scale up Avatar Placeholder (User Icon) image depending on the size parameter passed to the `<Image>` component * Add additional avatar image samples with various sizes to the Image documentation page * Resolve ESLINT warnings in `Icon.react.js`, `Image.react.js` and `ElementsImage.react.js` documentation page
* Add ability to have an `onClick` handler for items of a "basic" accordion and where item doesn't use `<Accordion.Summary>` and `<Accordion.Item>` but only passes in a `title` prop. * Tested the basic accordion onClick functionality on the documentation page * Fix all ESLINT issues in `Accordion.react.js` and `ModulesAccordion.react.js`
Contributor
Author
|
@IlyaRadinsky Thanks for the review; much appreciated. |
oilywithraybans
approved these changes
May 20, 2019
oilywithraybans
left a comment
oilywithraybans
left a comment
There was a problem hiding this comment.
Discussed with @aaronsampson and this PR is perfect for now. 
oilywithraybans
pushed a commit
that referenced
this pull request
Aug 3, 2019
[dev] Avatar (User Icon) Image Fixes/Enhancements for PBI AB#16313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xxlargesize option for<Icon>component<Image>componentIcon.react.js,Image.react.jsandElementsImage.react.jsdocumentation pageThe reason for this is I need the Avatar to potentially look like this:
https://sketch.cloud/s/vxGKM/bgDbkwo
@morethanfire Please review the styles and sizing logic for images and icons thoroughly. By logic I mean the "translation" from numeric sizes passed to
<Image>component to a fixed size option (small,medium,large, etc.) for<Icon>. I took a rough guess at it, and was able to get it doing this: