[dev] PBI AB#20206 [My Ministry > Members] [mobile] - Convert table to new mobile table#57
Merged
oilywithraybans merged 2 commits intosaddlebackdev:devfrom Sep 12, 2019
Conversation
oilywithraybans
approved these changes
Sep 12, 2019
oilywithraybans
left a comment
oilywithraybans
left a comment
There was a problem hiding this comment.
Dude, thanks for this work! A super simple feature, but I think it's a much needed one to facilitate us down the road. 
| isFiltersRailOpen: PropTypes.bool, | ||
| scrollable: PropTypes.bool, | ||
| style: PropTypes.object, | ||
| }; |
There was a problem hiding this comment.
Thanks for adding the defaults and checks!
| } | ||
| &.page--content-scrollable { | ||
| overflow-x: scroll; | ||
| } |
There was a problem hiding this comment.
I'm loving this new BEM naming convention! Event if .ui is sort of ruining it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@morethanfire Oops, I missed that the task https://saddlebackchurch.visualstudio.com/Church%20Management/_workitems/edit/20330 was removed 😕 so, if this feature not needed - just close this PR please.