Skip to content

[dev] Fixes in <ActionBarSearch /> and <ActionBarActionsButtonDrawerOption />#62

Merged
groberts314 merged 2 commits intodevfrom
features/action-bar-search-on-clear
Oct 4, 2019
Merged

[dev] Fixes in <ActionBarSearch /> and <ActionBarActionsButtonDrawerOption />#62
groberts314 merged 2 commits intodevfrom
features/action-bar-search-on-clear

Conversation

@groberts314
Copy link
Copy Markdown
Contributor

@groberts314 groberts314 commented Oct 3, 2019

  • Action Bar Search
    • Pass a search.onClearClick passed into column options prop passed to <Page.ActionBar /> into <ActionBarSearch />'s onClearClick prop (so, you know, we can actually use it! =)
    • Fix ESLINT where possible, otherwise suppress the warnings and errors with comments, all throughout src\modules\actionBar.js
  • Action Bar Buttons
    • Fix some issues with onClick bindings for the sub-options
    • Fix an issue having to do with positioning and trying to click a sub-option. In some cases the click first propagated to a different parent option that is visually "underneath" the sub-option but is apparently occupying that position! Thanks to @morethanfire for the simple fix (suppress "pointer events" when the colliding parent option is hidden)
    • Better code and styling support for disabling options and sub-options
    • Fix some ESLINT issues
  • Demo Page
    • Add more options and sub options to Demo Page, with click handlers on everything logs a distinct message to the console for each thing that is clicked.
    • Also add a disabled option and a disabled sub-options.
    • Fix all the ESLINT issues (and in the process newer React component code organization style per Airbnb Style Guide)

* Fix some issues with `onClick` bindings for the sub-options
* Fix an issue having to do with positioning and trying to click a sub-option.  In some cases the click first propagated to a different parent option that is visually "underneath" the sub-option but is apparently occupying that position!  Thanks to @morethanfire for the simple fix.
* Better code and styling support for disabling options and sub-options
* Add more options and sub options to Demo Page, with click handlers on everything logs a distinct message to the console for each thing that is clicked.  Also testing disabled options and sub-options.
* Fix all the ESLINT issues in Demo Page and a few other components
@groberts314 groberts314 changed the title [dev] Pass onClearClick into <ActionBarSearch /> + appease/suppress ESLINT [dev] Fixes in <ActionBarSearch /> and <ActionBarActionsButtonDrawerOption /> Oct 4, 2019
@groberts314 groberts314 merged commit f3e9171 into dev Oct 4, 2019
@groberts314 groberts314 deleted the features/action-bar-search-on-clear branch October 4, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant