[dev] Fixes in <ActionBarSearch /> and <ActionBarActionsButtonDrawerOption />#62
Merged
groberts314 merged 2 commits intodevfrom Oct 4, 2019
Merged
Conversation
* Fix some issues with `onClick` bindings for the sub-options * Fix an issue having to do with positioning and trying to click a sub-option. In some cases the click first propagated to a different parent option that is visually "underneath" the sub-option but is apparently occupying that position! Thanks to @morethanfire for the simple fix. * Better code and styling support for disabling options and sub-options * Add more options and sub options to Demo Page, with click handlers on everything logs a distinct message to the console for each thing that is clicked. Also testing disabled options and sub-options. * Fix all the ESLINT issues in Demo Page and a few other components
onClearClick into <ActionBarSearch /> + appease/suppress ESLINT<ActionBarSearch /> and <ActionBarActionsButtonDrawerOption />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search.onClearClickpassed into column options prop passed to<Page.ActionBar />into<ActionBarSearch />'sonClearClickprop (so, you know, we can actually use it! =)src\modules\actionBar.jsonClickbindings for the sub-options