Merged
Conversation
groberts314
reviewed
Oct 11, 2019
src/modules/details.js
Outdated
| horizontalSpacing = columnProps.horizontalSpacing; | ||
| } | ||
|
|
||
| let foo; |
Contributor
There was a problem hiding this comment.
We should probably rename this guy! :-)
groberts314
reviewed
Oct 11, 2019
Contributor
groberts314
left a comment
groberts314
left a comment
There was a problem hiding this comment.
Looks pretty good.
Lots of reaching into the DOM to make it happen, eh? If that's what it takes, c'est la vie.
One let foo; that could stand a better name, but definitely non-blocking ... we gotta get this shipped! :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.