Added Time From Now Function To DateUtils#76
Conversation
| y, | ||
| yy, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I imagine this actually mutates some state inside the global moment function/object definition? Are we okay with that? We've probably been doing it all along, so it's probably okay.
There was a problem hiding this comment.
It does, but using Moment's fromNow function I am not sure how else to go about it. Do you have any ideas?
There was a problem hiding this comment.
Nah, not really. It seems we essentially want to customize this part of moment's locale settings. In the future, we might consider some research into how moment handles these locale settings and maybe find some way to set these locale settings once, and not every time our timeFromNow() function is called. But that doesn't have to block this PR.
2 participants
No description provided.