iOS Drawer header fix and renaming of dateUtils and domUtils#78
Merged
groberts314 merged 4 commits intodevfrom Oct 24, 2019
Merged
iOS Drawer header fix and renaming of dateUtils and domUtils#78groberts314 merged 4 commits intodevfrom
groberts314 merged 4 commits intodevfrom
Conversation
groberts314
reviewed
Oct 24, 2019
Contributor
groberts314
left a comment
groberts314
left a comment
There was a problem hiding this comment.
Looks pretty good overall
| export { default as DatePickerUtils } from './utils/datePickerUtils.js'; | ||
| export { default as DateUtils } from './utils/dateUtils.js'; | ||
| export { default as DOMUtils } from './utils/domUtils.js'; | ||
| export { default as dateUtils } from './utils/dateUtils.js'; |
Contributor
There was a problem hiding this comment.
Gonna be a find/replace for the imports in HC I imagine?
Author
There was a problem hiding this comment.
Yeah. I thought about not doing this change just yet, but I don't believe it'll be that time consuming go forth.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.