Renamed Page/Drawer sub components#80
Conversation
oilywithraybans
changed the title
|
@morethanfire Looks like some overlap here with #79? |
groberts314
left a comment
groberts314
left a comment
There was a problem hiding this comment.
Looks good to me so far ... but seems still WIP?
| Page.Grid = PageGrid; | ||
| Page.Table = PageTable; | ||
| Page.Grid = PageDataCards; // TODO: Deprecated. Alias name for Page.DataCard. Remove in next major release. | ||
| Page.Table = PageDataGrid; // TODO: Deprecated. Alias name for Page.DataGrid. Remove in next major release. |
There was a problem hiding this comment.
How widespread is the usage in HC? Is it worth deprecating? Or should we kill altogether and replace all the references in HC?
There was a problem hiding this comment.
Not to wide. I will fix in dev and let everyone know of a possible regression and what to do for their branches. In my eyes, super simple fix.
There was a problem hiding this comment.
But you'd rather leave the old aliases just in case?
Honestly, I'm pretty certain we're the only consumers ... I'd almost rather remove, let it fail hard until fixed. Not the way we'd do things if it really were a shared library, and if you do want to do the deprecation and them remove in next major version, I am okay with that too.
docs/src/modules/pageDemo.js
Outdated
| }, | ||
| ]} | ||
| data={{ | ||
| birthday: '23/01/1990', |
There was a problem hiding this comment.
Can we do 1990-01-23 for a common format intelligible and agreeable to devs all over the world? =)
There was a problem hiding this comment.
changed to this and also added the accessor function statement
src/modules/dataGridTableRow.js
Outdated
| row: PropTypes.shape({}).isRequired, | ||
| rowIndex: PropTypes.number.isRequired, | ||
| rowProps: PropTypes.func, | ||
| sizes: PropTypes.arrayOf(PropTypes.arrayOf(PropTypes.object)), |
There was a problem hiding this comment.
Uh oh, PropTypes.object! Isn't that verboten these days per ESLINT? It's PropTypes.shape({}) now? =)
src/modules/dataGroup.js
Outdated
| import Header from '../elements/header.js'; | ||
| import List from '../elements/list.js'; | ||
| import DataGroupRow from './dataGroupRow.js'; | ||
| import DataGroupRow from './DataGroupRow.js'; |
2 participants
Uh oh!
There was an error while loading. Please reload this page.