Skip to content

[dev] AB# 21618 Ability to view a person’s occupation data on a person record - [R.2] [block size: 375 - 1386] [adult record only]#82

Merged
oilywithraybans merged 2 commits intosaddlebackdev:devfrom
fantaJinMode:features/implement-expandable-feature-datagroup
Nov 13, 2019
Merged

[dev] AB# 21618 Ability to view a person’s occupation data on a person record - [R.2] [block size: 375 - 1386] [adult record only]#82
oilywithraybans merged 2 commits intosaddlebackdev:devfrom
fantaJinMode:features/implement-expandable-feature-datagroup

Conversation

@fantaJinMode
Copy link
Copy Markdown
Contributor

PR contains :

  • Expand feature functionality
  • Fixing CSS gutters
  • Animation on expand

Simple Preview Video Link
https://www.loom.com/share/7f5103d6e27f4ee18562d3c995dd7f45

@oilywithraybans oilywithraybans self-requested a review November 12, 2019 16:36
Copy link
Copy Markdown

@oilywithraybans oilywithraybans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, just a couple requested changes.

Copy link
Copy Markdown

@oilywithraybans oilywithraybans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! I am going to merge this and work on removing the style bug we talked about earlier where it was dropping the last column below when expanding a prior column.

@oilywithraybans oilywithraybans merged commit 7f70f9f into saddlebackdev:dev Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants