fix(data-grid): date timezone issues and move utils to data-grid.ts#1085
Merged
Conversation
Owner
sadmann7
commented
Dec 31, 2025
sadmann7
commented
- Add parseLocalDate to parse YYYY-MM-DD as local date (avoids UTC shift)
- Add formatDateToString to format Date using local components
- Move getUrlHref, formatFileSize, getFileIcon to lib/data-grid.ts
- Fix DateCell to correctly display selected dates without off-by-one errors
- Add parseLocalDate to parse YYYY-MM-DD as local date (avoids UTC shift) - Add formatDateToString to format Date using local components - Move getUrlHref, formatFileSize, getFileIcon to lib/data-grid.ts - Fix DateCell to correctly display selected dates without off-by-one errors
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses timezone-related bugs in date handling within the data grid component and consolidates utility functions into a centralized location. The changes prevent off-by-one date errors that occurred when dates were being parsed and formatted through UTC conversion.
- Added new date utility functions (
parseLocalDate,formatDateToString,formatDateForDisplay) that work with local time components to avoid timezone shifts - Moved utility functions (
getUrlHref,formatFileSize,getFileIcon) from the component file to the centralizeddata-grid.tslibrary - Updated
DateCellcomponent to use the new local date parsing and formatting functions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib/data-grid.ts | Added new date utility functions and consolidated file/URL utilities from component file |
| src/components/data-grid/data-grid-cell-variants.tsx | Removed local utility functions, updated imports, and fixed DateCell to use new timezone-safe date functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.