Clarifying the "Unreachable vertices for sample" message

[stefanhannie]

Hi,

I want to make sure I'm understanding the "Unreachable vertices for sample" message found here:

corneto/corneto/methods/future/carnival.py

Line 230 in 0ab82c6

print(f"Unreachable vertices for sample: {len(unreachable)}")

I've done a little bit of debugging and I think this is only triggering when you run multiple samples through Carnival as this is flagging vertices that cannot be reached in the union graph of all of your samples when subsetting on a specific sample. Is this correct?

From the message, I assumed that these referred to vertices that were unreachable given my specified input and output vertices. But that doesn't seem to be the case. That seems to be happening silently in the prune_graph here:

corneto/corneto/methods/future/carnival.py

Lines 74 to 77 in 0ab82c6

	sub_graph = G.prune(list(inputs_in_graph), list(outputs_in_graph))
	subgraph_vertices = set(sub_graph.V)
	reachable_inputs.update(inputs_in_graph & subgraph_vertices)
	reachable_outputs.update(outputs_in_graph & subgraph_vertices)

---

Just wanted to confirm what was going on and maybe flag this in case others were getting confused by the message.

Thanks!

[pablormier]

Yes you're right that's what is happening, and I agree that this print statement is confusing, it will be removed in the future and instead the method should report metrics and details about which vertices could not be reached from the selected inputs and pkn. Thanks!