examples: add HOLD coverage for payment guard service#146
Merged
safal207 merged 1 commit intoMay 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HOLDbehavior for recurring payments that lack approval so mode semantics are fully demonstrated.enforceandshadowmodes and make the service-level audit expectations deterministic.Description
examples/agent-payment-guard/run_service_check.shto POST thepayment_proposal.recurring_without_approval.jsonfixture and assertHOLD+RECURRING_PAYMENT_REQUIRES_APPROVALinenforcemode.HOLDinshadowmode, verifyingexecution_alloweddiffers by mode whilewould_blockremains true.count==4and verify the explicit decision sequenceACCEPT, BLOCK, HOLD, HOLD.python3 scripts/verify_audit_log.py .proofpath/audit.jsonlcheck unchanged.Testing
bash examples/agent-payment-guard/run_demo_check.sh; it passed.bash examples/agent-payment-guard/run_service_check.sh; it passed and exercised bothHOLDcases.python3 scripts/verify_audit_log.py .proofpath/audit.jsonl; hash-chain verification passed.Codex Task