Skip to content

Fixes race conditions due to incorrect usage of PushUpdate or PushFunc#170

Merged
ppacher merged 3 commits into
feature/ui-revampfrom
fix/race-conditions
Oct 8, 2020
Merged

Fixes race conditions due to incorrect usage of PushUpdate or PushFunc#170
ppacher merged 3 commits into
feature/ui-revampfrom
fix/race-conditions

Conversation

@ppacher
Copy link
Copy Markdown
Contributor

@ppacher ppacher commented Oct 7, 2020

No description provided.

@ppacher ppacher added this to the UI Revamp milestone Oct 7, 2020
Copy link
Copy Markdown
Member

@dhaavi dhaavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Comment thread network/connection.go
Comment on lines +97 to +100
// Tunneled is currently unused and MUST be ignored.
Tunneled bool
// Encrypted is currently unused and MUST be ignored.
Encrypted bool
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are currently being worked on. Should we not add a description already?

@ppacher ppacher merged commit 67b3d76 into feature/ui-revamp Oct 8, 2020
@ppacher ppacher deleted the fix/race-conditions branch October 8, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants