Use deep equal in mutableValue #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@intersrc thanks! Could you add a test to cover that case? |
Author
|
The test added. Now use |
Author
|
Solved. |
Lexxus
reviewed
Dec 29, 2017
src/components/Select.vue
Outdated
| this.onChange ? this.onChange(val) : null | ||
| } else { | ||
| this.onChange && val !== old ? this.onChange(val) : null | ||
| this.onChange && JSON.stringify(val) !== JSON.stringify(old) ? this.onChange(val) : null |
Contributor
There was a problem hiding this comment.
This is not a good comparison because order of properties can be different but values can be equal, so as a result comparison will fail.
|
This is really an issue that needs to be fixed :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
val&oldare objects, like{ label, value },val !== oldis true, but they have samelabel&value, this may cause a dead loop.It's better to use a deep equal here.