Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point2d(iter([])) raises ValueError #14490

Closed
seblabbe opened this issue Apr 25, 2013 · 10 comments
Closed

point2d(iter([])) raises ValueError #14490

seblabbe opened this issue Apr 25, 2013 · 10 comments
Assignees
@jasongrout @williamstein
Labels
c: graphics p: major / 3 t: bug
Milestone
sage-7.3

Comments

@seblabbe
Copy link
Contributor

I just came up with the following bug. point2d takes list as input (possibly empty). It also takes an iterator as input, but it must be non empty which is not fun :

sage: point2d([])     # works, return empty graphic
sage: point2d(iter([]))
Traceback (most recent call last):
...
ValueError: points must have 2 coordinates in a 2d line

Component: graphics

Author: Frédéric Chapoton

Branch: 136a25e

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/14490
@seblabbe seblabbe added this to the sage-5.11 milestone Apr 25, 2013
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@sagetrac-jakobkroeker
Copy link
Mannequin

sagetrac-jakobkroeker mannequin commented Jul 9, 2016

comment:5

seems fixed in recent sage

@fchapoton fchapoton removed this from the sage-6.4 milestone Jul 11, 2016
@videlec
Copy link
Contributor

videlec commented Jul 11, 2016

comment:7

Since it was fixed by accident, it would be nice to add a doctest...

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Branch: public/14490

@fchapoton
Copy link
Contributor

Commit: 136a25e

@fchapoton
Copy link
Contributor

comment:8

done, please review

New commits:

136a25etrac 14490 adding doctest

@fchapoton fchapoton added this to the sage-7.3 milestone Jul 13, 2016
@videlec
Copy link
Contributor

videlec commented Jul 13, 2016

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Jul 13, 2016

Changed branch from public/14490 to 136a25e

@vbraun vbraun closed this as completed in fd26442 Jul 13, 2016
@seblabbe
Copy link
Contributor Author

comment:11

For reference, this ticket also solved #10948.

@seblabbe
Copy link
Contributor Author

Changed commit from 136a25e to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

@williamstein williamstein

Labels
c: graphics p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
7 participants
@jasongrout @vbraun @williamstein @seblabbe @jdemeyer @fchapoton @videlec