Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr

[mkoeppe]

In fact, we have 2 copies of coeff_repr and repr_lincomb: one in sage.misc.misc, one in sage.misc.latex. Perhaps they can be merged in a follow up ticket as well; and perhaps even #14509 be fixed...

sage.structure.formal_sum.FormalSum._latex_ has a comment (from nthiery 2012):

        return sage.misc.latex.repr_lincomb(symbols, coeffs)
        # TODO: finish merging sage.misc.latex.repr_lincomb and
        # sage.misc.misc.repr_lincomb and use instead:
        # return sage.misc.misc.repr_lincomb([[t,c] for c,t in self], is_latex=True)

Also sage.modular.modsym.element:

        # TODO: use repr_lincomb with is_latex=True
        return latex.repr_lincomb(v, c)

---

This ticket is part of an effort to reduce sage.misc.misc, motivated by #29865 (Modularization of sagelib: Break out a separate package sage-objects)

Depends on #29869

CC: @fchapoton @kcrisman @tscrim @slel @nthiery @DaveWitteMorris

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: b5f63a5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29892

[mkoeppe]

Dependencies: #29869

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Branch: u/mkoeppe/move_sage_misc_misc_coeff_repr__repr_lincomb_to_new_module_sage_misc_repr

[mkoeppe]

New commits:

907feeb	Move attrcall and friends from sage.misc.misc to new module sage.misc.call
a5453bf	Fixup: Add src/sage/misc/call.py
64c5701	lazy_import from sage.misc.call with deprecation
65414f7	Fix imports and one deprecation warning
b9314d4	sage.misc.call: Add standard header information, add to reference manual
6024ffd	src/sage/misc/call.py: register_unpickle_override for call_method
ab4e0fd	Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr

[mkoeppe]

Commit: ab4e0fd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3f5b6ea

Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr

[sagetrac-git]

Changed commit from ab4e0fd to 3f5b6ea

[sagetrac-git]

Changed commit from 3f5b6ea to 08fedfa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

08fedfa

src/sage/combinat/root_system/type_dual.py: Remove unused variable to fix pyflakes warning

[sagetrac-git]

Changed commit from 08fedfa to 05efc11

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

05efc11

sage.misc.repr.coeff_repr: Add doctest, adapted from sage.misc.latex.coeff_repr

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

538323b

src/sage/misc/call.py: Fix block syntax in docstring

[sagetrac-git]

Changed commit from 05efc11 to 538323b

[mkoeppe]

comment:15

Not sure what's up with the "block syntax" warning

[fchapoton]

comment:16

Returns should be Return

[sagetrac-git]

Changed commit from 538323b to b5f63a5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b5f63a5

src/sage/misc/call.py: Returns should be Return

[mkoeppe]

comment:18

Thanks!

[mkoeppe]

comment:19

The remaining plugin warnings are old news. Needs review

[tscrim]

comment:20

I agree with every change except for 08fedfa. This is used:

sage: CartanType.options.notation='Kac'
sage: CartanType(['BC', 4, 2]).dual()
['A', 8, 2]^+
sage: CartanType(['BC', 4, 2]).dual()._repr_(compact=True)
'A8^2+'

sage: CartanType.options.notation='Stembridge'
sage: CartanType(['BC', 4, 2]).dual()
['BC', 4, 2]^*
sage: CartanType(['BC', 4, 2]).dual()._repr_(compact=True)
'BC4~*'

It is suppose to represent the notation for affine Cartan type introduced by Kac of A_2n^(2)\dagger. There probably should be a doctest showing this though...

[mkoeppe]

comment:21

The function delegates to CartanType._repr_ in this case, which computes dual_str again and uses it

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:22

Ah, I see. I was looking at the wrong _repr_. There seems to be some redundant code that probably should be cleaned up. A good starter ticket for a new developer.

LGTM. Thanks.

[mkoeppe]

comment:23

Thanks!

[vbraun]

Changed branch from u/mkoeppe/move_sage_misc_misc_coeff_repr__repr_lincomb_to_new_module_sage_misc_repr to b5f63a5