-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate sage.misc.misc.sage_makedirs #32987
Comments
This comment has been minimized.
This comment has been minimized.
Dependencies: #32986 |
Commit: |
New commits:
|
Author: Matthias Koeppe |
comment:5
It works well. I see two doctest failures with |
Reviewer: Kwankyu Lee |
comment:6
Thank you! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
|
Changed dependencies from #32986 to none |
comment:9
Rebased away from #32986 (which is stuck) |
Changed reviewer from Kwankyu Lee to Kwankyu Lee, Michael Orlitzky |
comment:10
This was already positively reviewed, but LGTM too after rebasing. |
comment:11
Thanks! |
Changed branch from u/mkoeppe/deprecate_sage_misc_misc_sage_makedirs to |
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Remove code deprecated in - sagemath#32987 (2022) - sagemath#33213 (2022) - sagemath#29869 (2020) - sagemath#17815 (2020) - sagemath#29892 (2020) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37868 Reported by: Matthias Köppe Reviewer(s): Michael Orlitzky
As noted in #29093, in py3,
os.makedirs
learned anexist_ok
option that makessage_makedirs
entirely redundant.https://docs.python.org/3/library/os.html#os.makedirs
Since then we have dropped py2 support, so we can deprecate
sage_makedirs
and replace all uses in the library.CC: @mezzarobba @orlitzky
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
d3b3252
Reviewer: Kwankyu Lee, Michael Orlitzky
Issue created by migration from https://trac.sagemath.org/ticket/32987
The text was updated successfully, but these errors were encountered: