Uploading an image directly into Cocalc Jupyter does nothing

[johnjeng]

Reproduction steps:

1. Create a Jupyter Notebook
2. Create a markdown cell
3. Click on the cell
4. Insert an image via the edit menu:

5. Select and upload an image.
6. Nothing happens

What should happen:

An image attachment gets inserted like so

[williamstein]

I assume your "What should happen" is taken from (maybe even a screenshot of) the official Jupyter client?

[haraldschilly]

Here is the stacktrace

Uncaught (in promise) TypeError: opts.until is not a function
    at JupyterStore.Store.wait (webpack-internal:///./smc-webapp/app-framework/Store.ts:147)
    at JupyterActions.eval (webpack-internal:///./smc-webapp/jupyter/actions.ts:2815)
    at step (webpack-internal:///./smc-webapp/jupyter/actions.ts:57)
    at Object.eval [as next] (webpack-internal:///./smc-webapp/jupyter/actions.ts:38)
    at eval (webpack-internal:///./smc-webapp/jupyter/actions.ts:32)
    at new Promise (<anonymous>)
    at __awaiter (webpack-internal:///./smc-webapp/jupyter/actions.ts:28)
    at JupyterActions._this.add_attachment_to_cell (webpack-internal:///./smc-webapp/jupyter/actions.ts:2800)
    at Dropzone.InsertImage._this.add_file (webpack-internal:///./smc-webapp/jupyter/insert-image.tsx:68)
    at Dropzone.Emitter.emit (webpack-internal:///./smc-webapp/node_modules/react-dropzone-component/dist/react-dropzone.js:187)

[williamstein]

I pushed a fix for that stacktrace, but the bug is still there. This was a tricky thing to implement in the first place...

[williamstein]

A workaround is to upload the file to the Files listing, then reference that image in the markdown, e.g., using e.g.,

<img src='foo.png' width=50%>

The drawback is that the image is not inside the ipynb file, which makes sharing the file harder.

[williamstein]

NOTE: you must restart your project (if it is running) too get this fix, since it's mainly on the backend.

[williamstein]

This is broken again, though it was fixed. Weird.