Skip to content

Conversation

@andras-markos
Copy link

Some minor refactorings are also included.

Please first review the previous PR!

…ctorings to satisfy all enabled Checkstyle rules
@andras-markos andras-markos changed the title Enabled Checkstyle and reformatted code [LT-1633] Enabled Checkstyle and reformatted code Aug 15, 2025
@bge-kernel-panic bge-kernel-panic changed the base branch from master to LT-1633-update-gradle-and-circleci-config August 15, 2025 15:35
@bge-kernel-panic
Copy link

@andras-markos I would not recommend those reformatting changes, as annoying as working with a non-standard format can be. Those changes will 100% ensure you will never be able to pull changes from the original project without a huge headache of having to resolve a bazillion conflicts.

My recommendation is to follow the original project's code formatting standards, as annoying as that may be.

Base automatically changed from LT-1633-update-gradle-and-circleci-config to master August 19, 2025 05:17
@andras-markos
Copy link
Author

@andras-markos I would not recommend those reformatting changes, as annoying as working with a non-standard format can be. Those changes will 100% ensure you will never be able to pull changes from the original project without a huge headache of having to resolve a bazillion conflicts.

My recommendation is to follow the original project's code formatting standards, as annoying as that may be.

Yeah, that makes sense.
I'll just decline this PR as the other one already has the bug fix and the Gradle build config update.
We can just keep Checkstyle off for this fork then. 😞

@andras-markos andras-markos deleted the LT-1633-checkstyle-reformat branch August 19, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants