loader: introduce component adapter and route backend calls#219
Closed
loader: introduce component adapter and route backend calls#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
sixel_loader_component_tabstraction with vtable and thin wrappers (ref,unref,setopt,load,get_name) insrc/loader-component.h/src/loader-component.c.loader-component-legacy(src/loader-component-legacy.h/src/loader-component-legacy.c) that wraps existingsixel_loader_entry_tbackends and mapssetoptoptions to the legacy backend call signature.sixel_loader_load_file()to create a legacy component per candidate registry entry, apply loader options viasetopt(loader_apply_component_options) and invoke decoding usingcomponent->load()instead of callingentry->backend(...)directly.src/meson.build,src/Makefile.am,src/Makefile.in) so normal and amalgamated builds include the new files.Testing
source /workspace/.local/env-autotools.sh && autoreconf -fi && ./configure && make -j4, and the build completed successfully (pass).source /workspace/.local/env-autotools.sh && ./configure && make check, and the test suite completed with a single unrelated network test failure:io/network/0006_invalid_https_error_message(1 fail, other tests passed or skipped); this failure appears not to be related to the introduced loader component changes (meson setup builddir --wipe && meson compile -C builddir && meson test -C builddir, and the test run also produced the same single network test failure (most tests passed, 1 fail) (meson setup builddir-amalgamated -Damalgamated_tools=true -Damalgamated_lib=true && meson compile -C builddir-amalgamatedand./configure --enable-amalgamated-lib --enable-amalgamated-tools && make -j4), and those builds completed successfully (pass).Codex Task