Fix bugs in python sixel_encoder_encode_bytes#223
Merged
saitoha merged 1 commit intosaitoha:masterfrom Apr 14, 2026
Merged
Conversation
Data length incorrect error message uses buf.len, but this does not exist, correct function is len(buf), as used on previous line. Argument type check via ctype was setting args to the wrong function from libsixel. The palette length when no palette is specified was passed as None, it should be 0. This error is detected after argument type checking is fixed. cbuf is created from buf argument, but it's not done correctly. What it does is make a pointer the address made from the first 32/64 bits of data in the buffer. I.e., it makes a pointing using the image pixels as if they were a pointer. That makes a random pointer to nowhere. But cbuf is never used, so this code can just be deleted. ctypes will convert a bytes() object or various other things into the correct type without help.
Owner
|
@xyzzy42 Thank you.
I’m not sure why these mistakes happened, but all of your points are correct, and your code looks good. This fix will be merged into the next version, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data length incorrect error message uses buf.len, but this does not exist, correct function is len(buf), as used on previous line.
Argument type check via ctype was setting args to the wrong function from libsixel.
The palette length when no palette is specified was passed as None, it should be 0. This error is detected after argument type checking is fixed.
cbuf is created from buf argument, but it's not done correctly. What it does is make a pointer the address made from the first 32/64 bits of data in the buffer. I.e., it makes a pointing using the image pixels as if they were a pointer. That makes a random pointer to nowhere.
But cbuf is never used, so this code can just be deleted. ctypes will convert a bytes() object or various other things into the correct type without help.