Skip to content

Conversation

@andyb
Copy link

@andyb andyb commented Feb 26, 2015

I've moved the defer call after error check to prevent panic when file not found.

@mish15
Copy link
Member

mish15 commented Feb 26, 2015

@andyb thanks for the PR. From memory I put it there for a reason. I think it's possible to have a file and an error (?), which would cause a mem leak. Will have a look in the morning. Cheers!

@andyb
Copy link
Author

andyb commented Feb 26, 2015

No problem, thanks for the useful package! If it needs to be there maybe a nil check will suffice to stop the panic. Let me know if you need me to change anything.

@mish15
Copy link
Member

mish15 commented Feb 26, 2015

Yep no worries. Definitely need to get rid of the panic! Will have a play
in the morning.

On Thursday, 26 February 2015, Andy Britcliffe notifications@github.com
wrote:

No problem, thanks for the useful package! If it needs to be there maybe a
nil check will suffice to stop the panic. Let me know if you need me to
change anything.


Reply to this email directly or view it on GitHub
#6 (comment).

Hamish Ogilvy
Sajari Pty Ltd
_t: +61 (_0) 414 658 353 | e: *hogilvy@sajari.com
*w:
www.sajari.com

@mish15
Copy link
Member

mish15 commented Feb 27, 2015

Closing in favour of 61f9ca2

@mish15 mish15 closed this Feb 27, 2015
This was referenced Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants