Add WebAssembly (Wasm) support for zoomable module.#132
Conversation
saket
left a comment
There was a problem hiding this comment.
This is great, thank you @Phaestion!
|
:zoomable-image:core - Tests were flaky! ✅ 163 passed / First failure encountered:
There were more failures, click for details |
|
Hi @saket. I see one screenshot test failed, but this does not look like this has anything to do with the wasm parts I added. |
|
Yea I'm not sure what's up with that test. I was hoping to set aside some time, but life has kept me busy in the past few weeks. Let me merge this -- I'll investigate the test later. |
|
Thanks! I totally know what you mean @saket. Could you make a release? I would very much like to use an upstream release in our apps. |
|
@Phaestion 0.16.0 is now available: https://github.com/saket/telephoto/releases/tag/0.16.0 |
Hi @saket
Thanks for an awesome library! We're developing quite a bit of Kotlin Multiplatform apps and we have a strong focus on rendering documents using KMP. Even though most of our users would typically use Android and iOS we have quite a bit of internal config tools that we run on web via WASM.
Given that your library doesn't support WASM yet we couldn't use it for our base libraries that our products and ultimately our config tools depend on.
So I endeavoured to add WASM support specifically for the
zoomablemodule, it turned out to be pretty easy. The build seems to work fine for all existing modules. I built a snapshot version and published tomavenLocaland tested it out with one of our configuration tools, this seems to work well with the double click to zoom function.See attached recording showing it works in browser with one of our config tools.
