Add popup rule-retention option for disabling vs deleting rules#527
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/salarcode/SmartProxy/sessions/f6085f67-e788-497a-ac13-f21d1a66ab9e Co-authored-by: salarcode <1272095+salarcode@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <label class="mx-2 form-label"> | ||
| <input id="chkRefreshTabOnConfigChanges" checked type="checkbox" | ||
| class="form-check-input" /> | ||
| <span data-localize="settingsGeneralRefreshTabOnConfigChanges">Refresh active tab when | ||
| proxy profile changed</span> | ||
| </label> | ||
| <br /> | ||
| <label class="mx-2 form-label"> | ||
| <input id="chkDeleteRuleWhenDisabledFromPopup" type="checkbox" class="form-check-input" /> | ||
| <span data-localize="settingsGeneralDeleteRuleWhenDisabledFromPopup">Delete rule when | ||
| disabled/unchecked from popup menu</span> | ||
| </label> | ||
| </div> |
There was a problem hiding this comment.
The newly added lines appear to use different line endings than the surrounding file (existing lines show CRLF while these lines are LF-only), which can leave the file with mixed EOLs and cause noisy diffs/formatting issues. Please normalize settings.html to a single line-ending style (preferably whatever the repo already uses) and re-save the file.
Disabling a rule from the popup currently removes it, which makes accidentally unchecked or complex rules hard to recover. This change adds a configurable option in General Options to choose whether popup uncheck deletes the rule or only disables it, with the new default preserving the rule.
Behavior change in popup rule toggling
enabled = falseinstead of removing the rule.Persisted settings
deleteRuleWhenDisabledFromPopuptoGeneralOptionsSettings UI
Delete rule when disabled/unchecked from popup menuLocalization
Focused coverage