fix tree-sitter install on node 24#27
Open
qingliaowu wants to merge 1 commit into
Open
Conversation
This was referenced May 13, 2026
awli
pushed a commit
that referenced
this pull request
May 13, 2026
The Prerequisites section listed only "Node.js >= 20 and pnpm >= 8", missing the tree-sitter CLI requirement that `pnpm build` needs to generate the parser in `packages/parser-tree-sitter`. New contributors hit "sh: tree-sitter: command not found" with no guidance from the README. Recommends `mise install` as the primary setup path (respects the pinned 0.25.x line in mise.toml) and provides a manual-install fallback that explicitly lists Node 22, pnpm 10, and the tree-sitter CLI 0.25.x. Calls out the macOS Homebrew gotcha: `brew install tree-sitter` ships only the C library; the CLI is a separate `tree-sitter-cli` formula (which currently ships 0.26.x, a minor mismatch with the pin). Addresses #33 Part B (the undocumented CLI prerequisite). Part A (Node 26 compatibility) is covered by #23 and #27. Refs #33
Contributor
|
Hi @qingliaowu, thanks for this contribution! The lack of default compatibility with C++20 in tree-sitter has bugged me for a while, so thanks for looking at this. Could you let me know your thoughts about whether it's ok to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tree-sitter@0.25.0so its native binding builds with C++20 instead of C++17.Why
Fixes #7.
Node 24 V8 headers require C++20, but
tree-sitter@0.25.0forces C++17 inbinding.gyp. That makespnpm installfail when the native binding compiles under Node 24.How
The pnpm patch updates the upstream package build flags for Unix, macOS/Xcode, and Windows/MSVC to C++20. The new CI job runs
pnpm install --frozen-lockfileon Node 24 so the install path is checked directly.Test Plan
corepack pnpm install --frozen-lockfileon Node v24.10.0 withoutCXXFLAGScorepack pnpm rebuild tree-sitteron Node v24.10.0 withoutCXXFLAGSnode --test packages/parser-tree-sitter/bindings/node/*_test.jscorepack pnpm --filter @agentscript/parser testcorepack pnpm exec prettier --check .github/workflows/ci.yml package.json pnpm-lock.yamlcorepack pnpm --filter @agentscript/parser-tree-sitter test(local machine is missing the externaltree-sitterCLI; its Node binding subtest passed)Checklist