Added the page header component and associated demo page #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| render(){ | ||
| return ( | ||
| <SLDSPageHeader> |
There was a problem hiding this comment.
no need to have whole class into code snippet:
just put there JSX it should work
eg: see DropDownExamples1.js
Author
|
Refactoring based on comments. |
|
@tweettypography You might also want to take a look at this |
Author
|
@arunjeetsingh In the middle of refactoring I would not recommend merging until I update the PR with my next commit. |
Refactored PageHeader component
ghost
Author
|
I have refactored the component to follow the "primitive component" design pattern (per a discussion with Ivan). Tests still need to be written for the new SLDSPageHeader component. |
|
@hansoksendahl Don't see any updates on the code. Did you push it? |
Author
|
Yes, the code has been updated, I squashed my commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work adds the SLDSPageHeader component.