Skip to content

Don't render the lookup label if the label is empty #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Don't render the lookup label if the label is empty #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/SLDSLookup/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,16 @@ class SLDSLookup extends React.Component {
let componentClasses = this.state.selectedIndex === null ? "slds-lookup ignore-react-onclickoutside":"slds-lookup ignore-react-onclickoutside slds-has-selection";
let inputContainerClasses = this.state.selectedIndex === null ? '':' slds-input';
let inputContainerStyle = this.state.selectedIndex === null ? {} : {padding: '5px'};
let inputLabel;
if (this.props.label) {
inputLabel = <label className="slds-form-element__label" htmlFor={this.props.type + "Lookup"}>{this.props.label}</label>
}

return (
<div className={componentClasses} data-select="multi" data-scope="single" data-typeahead="true">
<section className="slds-form-element">

<label className="slds-form-element__label" htmlFor={this.props.type + "Lookup"}>{this.props.label}</label>
{inputLabel}

<div className={"slds-lookup__control slds-input-has-icon slds-input-has-icon--right" + inputContainerClasses} style={inputContainerStyle}>
{ this.state.selectedIndex !== null ? this.renderSelectedItem() : null }
Expand Down