Skip to content

Lookups refactor #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivanbogdanov merged 19 commits into from
Oct 2, 2015
Merged

Lookups refactor #9

ivanbogdanov merged 19 commits into from
Oct 2, 2015

Conversation

@donnieberg
Copy link
Contributor

@donnieberg donnieberg commented Oct 1, 2015

@madpotato Lookup component has bug when you filter list and select item onClick because indexes map to the static array of items, not to the filtered list of items. Need help strategizing a solution.

To recreate bug:

  1. type "pa" into input field which filters list to two items
  2. select second item "Paper St. Soap Company" (index 1 in filtered list)
  3. "Tyrell Corp" is wrongly selected because it has the index 1 in the unfiltered list

@donnieberg
Remove SLDSPopover wrapper and add aria markup to input on lookup com…
9f02d02 
…ponent
@donnieberg
Add hover styling for keyboard interactions on lookup menu items
cd2e727
@donnieberg
Add keyboard interaction for activedescendent
4b343e4
@donnieberg
Move lookup body item to separate file
af55360
@donnieberg
Add keyboard up/down interaction on lookup menu items
ade0e0d
@donnieberg
Clean up. Hooke up keyboard functionality to set activeDescendant but…
6e177ca 
… is not setting item yet.
@donnieberg
Fix merge error: removed pages/HomePage.jsx which is replaced by page…
732afda 
…s/HomePage/index.js
@donnieberg
Temporarily make input class slds-input to get outline back
f263480
@donnieberg
Remake template for lookup/index and menu/index
9c462e5
@donnieberg
Add input listeners
25efcba
@donnieberg
Add back in search filter with highlighting styles
d0dc4e9
@donnieberg
Hook up activedescendant to change with active item on up/down arrow …
f97d15f 
…keys
@donnieberg
Fix small bug with the aria-activedescendant
0201006
@donnieberg
Make onClick select item from list
f577cf6
@donnieberg
Remove old lookup files
a2e8dbb
@donnieberg
Add styling for single select lookup based on SLDS
31183d3
@donnieberg
Merge branch 'master' into lookups-refactor
51fdd9b
@donnieberg
Link up key/space keys to trigger selectItem
75b7a62
@donnieberg
Fix filtering bug introduced by items as objects vs. strings
3fb3391
ivanbogdanov pushed a commit that referenced this pull request Oct 2, 2015
@ivansfdc
Merge pull request #9 from salesforce-ux/lookups-refactor
abe4ee7 
Lookups refactor
@ivanbogdanov ivanbogdanov merged commit abe4ee7 into master Oct 2, 2015
donnieberg added a commit that referenced this pull request Dec 17, 2015
@donnieberg
Merge pull request #9 from ux/master
a8c89cf 
Update git.soma.pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donnieberg @ivanbogdanov