fix: use backwards-compatible configuration for decorators plugin #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I initially believed that configuring this package to use decorators-legacy would be backwards-compatible but now I'm not so sure. We either need to figure out how to configure decorators-legacy such that our eslint rules work correctly and verify that this configuration is compatible with the new decorators proposal (unlikely), or to require consuming applications to align with this package and move to the new decorators proposal. If neither of these options are feasible, then we should revert back to |
avoid possibility of using decorators/decorators-legacy together
ekashida
force-pushed
the
ekashida/decorators-compatible-configuration
branch
from
935b345 to
2ba84c7
Compare
pmdartus
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the "Parsing error: Cannot use the decorators and decorators-legacy plugin together" parsing error when the consuming application uses the legacy decorators plugin. This configuration causes no issues when the consuming application is using the new decorators plugin.