Skip to content

Conversation

@cbornet
Copy link
Contributor

@cbornet cbornet commented Nov 6, 2017

Or was there a reason not to use the API directly ?

@salesforce-cla
Copy link

salesforce-cla bot commented Nov 6, 2017

Thanks for the contribution! Before we can merge this, we need @cbornet to sign the Salesforce Contributor License Agreement.

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage     58.25%   58.25%           
  Complexity      188      188           
=========================================
  Files            40       40           
  Lines           915      915           
  Branches         67       67           
=========================================
  Hits            533      533           
  Misses          359      359           
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...n/java/com/salesforce/rxgrpc/stub/ServerCalls.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b4abd...8c0786b. Read the comment docs.

@rmichela
Copy link
Collaborator

rmichela commented Nov 6, 2017

Is this to make it easier to split out the reactive code?

@cbornet
Copy link
Contributor Author

cbornet commented Nov 6, 2017

No. It's just to simplify the code.

@rmichela rmichela merged commit f51ac1c into salesforce:master Nov 8, 2017
@cbornet cbornet deleted the lambdasubscriber branch November 8, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants