Skip to content

Remove LambdaSubscriber wrapping and use subscribe directly #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Remove LambdaSubscriber wrapping and use subscribe directly #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rxgrpc/rxgrpc-stub/src/main/java/com/salesforce/rxgrpc/stub/ServerCalls.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import io.grpc.stub.StreamObserver;
import io.reactivex.Flowable;
import io.reactivex.Single;
import io.reactivex.internal.subscribers.LambdaSubscriber;
import io.reactivex.schedulers.Schedulers;
import org.reactivestreams.Subscriber;

Expand Down Expand Up @@ -132,7 +131,7 @@ public static <TRequest, TResponse> StreamObserver<TRequest> manyToMany(
Subscriber<TResponse> subscriber = new RxFlowableBackpressureOnReadyHandler<>(
(ServerCallStreamObserver<TResponse>) responseObserver);
// Don't try to respond if the server has already canceled the request
rxResponse.subscribe(new LambdaSubscriber<>(
rxResponse.subscribe(
tResponse -> {
if (!streamObserverPublisher.isCanceled()) {
subscriber.onNext(tResponse);
Expand All @@ -149,7 +148,7 @@ public static <TRequest, TResponse> StreamObserver<TRequest> manyToMany(
}
},
subscriber::onSubscribe
));
);
} catch (Throwable throwable) {
responseObserver.onError(prepareError(throwable));
}
Expand Down